Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the configuration format #5

Open
bipster opened this issue Jan 12, 2020 · 4 comments
Open

Allow specifying the configuration format #5

bipster opened this issue Jan 12, 2020 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@bipster
Copy link

bipster commented Jan 12, 2020

The plugin currently has an undocumented requirement for the JSON configuration, so if a project has an existing YAML config, that's silently ignored. Allowing this to be specified, or at least making the requirement clear in the docs, would help adoption for projects that require excluded files/directories.

@bipster
Copy link
Author

bipster commented Jan 12, 2020

Actually, I think I misunderstood the code. Does the plugin look at the project's CodeClimate config at all (e.g. if there's a .codeclimate.json file in the root)? The analysis via the plugin never finishes, which I solved via command-line by excluding files via the config.

@nhat-phan
Copy link
Owner

@bipster you're right, if you want to exclude you have to use codeclimate configuration file. Anyway, I have a plan to support multiple codeclimate projects in next release, hope it helps.

@nhat-phan nhat-phan added the documentation Improvements or additions to documentation label Jan 12, 2020
@bipster
Copy link
Author

bipster commented Jan 12, 2020

Thanks, @nhat-phan !

Even when I exclude all files via the config file, the plugin still claims there are 1,200,000 lines of code and I have to kill it after half an hour of no results. When I do the same via the command line it finishes in seconds.

I think I just realized the problem:

My folder structure is like this:

/project_root/.codeclimate.json
/project_root/module1/
/project_root/module2/
/project_root/module3/
/project_root/module4/

When I am running the CLI, I run it from /project_root.
But in my IntelliJ project, I don't load /project_root -- my project is set up so only the four modules are loaded. I think I have to move my .codeclimate.json into /project_root/module1 and exclude paths like "../module2/excluded.txt"?

@bipster
Copy link
Author

bipster commented Jan 12, 2020

I tried to let the plugin analyzation go as long as it needed but get "error: (CC::CLI::Analyze::EngineFailure) engine duplication ran for 900 seconds and was killed". I increased IJ's memory to 4G, and Docker's to 5G, but the CPU still runs at 400+% and the memory usage spikes. Neither happens when I run from the command-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants