Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/effects: Add migration schematic for concatLatestFrom operator #4262

Closed
1 of 2 tasks
markostanimirovic opened this issue Feb 22, 2024 · 3 comments · Fixed by #4311
Closed
1 of 2 tasks

@ngrx/effects: Add migration schematic for concatLatestFrom operator #4262

markostanimirovic opened this issue Feb 22, 2024 · 3 comments · Fixed by #4311
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Effects

Comments

@markostanimirovic
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

effects

Information

Before:

import { concatLatestFrom } from '@ngrx/effects';

After:

import { concatLatestFrom } from '@ngrx/operators';

The schematic should also add @ngrx/operators package to package.json => dependencies if it's not already installed.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@rainerhahnekamp
Copy link
Contributor

If no one's interested, I'd like to take that one. I have some experience in writing schematics (see https://github.com/rainerhahnekamp/sam4sc)

@markostanimirovic markostanimirovic added the community watch Someone from the community is working this issue/PR label Feb 27, 2024
@markostanimirovic
Copy link
Member Author

Thanks Rainer!

@rainerhahnekamp
Copy link
Contributor

@markostanimirovic and @timdeschryver. Thanks as well. I'd create then a schematic for the component store as well. See #4261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Effects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants