Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngrok Agent: add an AutoUpdate option #2

Open
russorat opened this issue May 14, 2024 · 1 comment
Open

ngrok Agent: add an AutoUpdate option #2

russorat opened this issue May 14, 2024 · 1 comment
Labels
area/ngrok-agent enhancement New feature or request

Comments

@russorat
Copy link
Collaborator

russorat commented May 14, 2024

From @SecretRecipe: inconshreveable/ngrok#917

Is there an autoupdate: true option available for the config?

If not; can we get one?

@russorat
Copy link
Collaborator Author

russorat commented May 14, 2024

Thanks for the issue. The check for a new version is available but the agent will not automatically restart to pick it up.

Do you need to specify a specific time for the restart to happen? We could just be smart and try to do it when we haven't seen a connection for a period of time.

The way i imagine this would work would be:

  • if update_check is true
    • if restart_on_update (new flag) is set to true (default false)
      • install the latest ngrok agent update and restart

This flag would be specific to the ngrok agent, not the sdks.

I would not expect this to work across major version upgrades (v3 to v4 for example) but minor and patch updates would probably be fine.

@russorat russorat added enhancement New feature or request area/ngrok-agent labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ngrok-agent enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant