-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root-cas setting #371
Merged
Merged
root-cas setting #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
labels
May 2, 2024
Looks to be working as expected:
with the standard agent ingress, which uses the internal ngrok CA rather than Let's Encrypt. |
From meeting today:
A table @jrobsonchase made of options, for posterity. We're going with the middle option: |
bobzilladev
reviewed
May 21, 2024
bobzilladev
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/controller
Issues dealing with the controller
area/helm-chart
Issues dealing with the helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #369
What
Utilizes the
trusted
orhost
CA as the source of truth via a helm install flag.How
Takes an install option for
--set rootCAs=host
and plumb theisHostCA
check into thecaCerts
for it to just get the host certs.Verification
--set rootCAs host
and make deploy, no controller errors ✅ and can play example--set rootCAs host
with canonical 2048 example without cert gives errors in controller--set rootCAs trusted
no errors and plays 2048 as expected