Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update https://ngrok.github.io/kubernetes-ingress-controller/ #308

Open
russorat opened this issue Sep 27, 2023 · 7 comments
Open

Update https://ngrok.github.io/kubernetes-ingress-controller/ #308

russorat opened this issue Sep 27, 2023 · 7 comments
Labels
area/helm-chart Issues dealing with the helm chart bug Something isn't working needs-triage Issues that need triage

Comments

@russorat
Copy link
Contributor

Kubernetes Version

latest

Helm Chart Version

latest

Helm Chart configuration

No response

What happened

The page hosted at https://ngrok.github.io/kubernetes-ingress-controller/ is in need of some updates. I can see the following:

  • Ngrok should be ngrok
  • We are out of Alpha status
  • We should link to the documentation instead of under contruction
  • remove the bit about configuring the agent

What you think should happen instead

No response

How to reproduce

No response

@russorat russorat added bug Something isn't working area/helm-chart Issues dealing with the helm chart needs-triage Issues that need triage labels Sep 27, 2023
This was referenced Sep 27, 2023
@CK-Ward
Copy link
Contributor

CK-Ward commented Nov 1, 2023

@russorat is this still applicable? looks like the work here is done

@russorat
Copy link
Contributor Author

russorat commented Nov 2, 2023

looks pretty good! i still see broken images at the top of the page:
image

@russorat
Copy link
Contributor Author

it looks like these images are still broken

@bobzilladev
Copy link
Member

Should be fixed next release, due to #333

@alex-bezek
Copy link
Collaborator

image
This does still seem to be an issue

@bobzilladev
Copy link
Member

bobzilladev commented Mar 4, 2024

Ah, the artifacthub logo is fixed (and i was able to get us "verified" and "official" there, as well as removing the old version with the different project name).

But the link in the github readme here isn't updated, pry just need to make the same change as main has in the special branch for the github page (gh-pages)

@bobzilladev
Copy link
Member

bobzilladev commented Mar 4, 2024

Ah, gh-pages is missing the current docs/assets/, pr to fix: #348

Edit: merged, page fixed: https://ngrok.github.io/kubernetes-ingress-controller/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-chart Issues dealing with the helm chart bug Something isn't working needs-triage Issues that need triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants