Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting up a new domain, we shouldn't have as many reconcile errors #195

Open
alex-bezek opened this issue Mar 21, 2023 · 0 comments
Open
Labels
area/controller Issues dealing with the controller bug Something isn't working priority/medium

Comments

@alex-bezek
Copy link
Collaborator

What happened

When creating an ingress object with a new hostname that needs to be registered, the edge controller will loop and error until the domain is reserved.

2023-03-21T19:19:52Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "038a355c-a379-4ace-ae32-4148cd49286d", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5g6JzubSRP4l9enEJdqBpcM"}
2023-03-21T19:19:52Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "4d22dd1a-27e7-4137-8fa9-fe5c44e80feb", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5c2gDDzfr0AKyR0lCukfuu2"}
2023-03-21T19:19:52Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "ec8e6135-fae2-4335-9813-1569db98a153", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5aLPQPCSBR44Vd0jqNGr8VB"}
2023-03-21T19:19:52Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "59c40f30-5773-4d8a-9a9c-9412d13e06fb", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5beJi1u0icJrcFJwZLr6Jhx"}
2023-03-21T19:19:52Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "72800a43-3d75-4dd1-8760-13f688426096", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5ZIrdg9FCOIT0SLhPWpIqz9"}
2023-03-21T19:19:53Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "69891cba-1ea2-4ab5-9bf7-a7f4be020cc7", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5kUoP0SkmCqYhPrGeLuOeou"}
2023-03-21T19:19:53Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "c4cc3989-75c3-4013-9035-61f87c3648a5", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5hanBYmErM0vtKZC1yRTEPf"}
2023-03-21T19:19:53Z	ERROR	Reconciler error	{"controller": "httpsedge", "controllerGroup": "ingress.k8s.ngrok.com", "controllerKind": "HTTPSEdge", "HTTPSEdge": {"name":"my-hostname-com","namespace":"default"}, "namespace": "default", "name": "my-hostname-com", "reconcileID": "4315c5a3-7b1b-4587-8645-59bfe56520fa", "error": "HTTP 400: The domain 'my-hostname.com:443' is not reserved. [ERR_NGROK_7117]\n\nOperation ID: op_2NKx5nurrZngH0TbHoxeBnvTLUB"}
2023-03-21T19:19:54Z	DEBUG	events	Updating Domain my-hostname-com	{"type": "Normal", "object": {"kind":"Domain","namespace":"default","name":"my-hostname-com","uid":"e1e0d98a-86e2-4aa3-b14e-b6a7d3b72ec4","apiVersion":"ingress.k8s.ngrok.com/v1alpha1","resourceVersion":"230225422"}, "reason": "Updated"}

What you think should happen instead

I'm not sure if this should actually be an error log? Its difficult because you don't know if it will resolve eventually.

At the very least, maybe we should error and re-queue with a wait period as it seems to just keep trying

How to reproduce

Create a new ingress with a new hostname that's not registered in your account yet

@alex-bezek alex-bezek added bug Something isn't working area/controller Issues dealing with the controller needs-triage Issues that need triage labels Mar 21, 2023
@alex-bezek alex-bezek added priority/medium and removed needs-triage Issues that need triage labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller bug Something isn't working priority/medium
Projects
None yet
Development

No branches or pull requests

1 participant