Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw content-loader not working #72

Open
bjornharvold opened this issue Nov 13, 2020 · 6 comments
Open

Raw content-loader not working #72

bjornharvold opened this issue Nov 13, 2020 · 6 comments

Comments

@bjornharvold
Copy link

Upgraded to Angular 11

facebook, list and bullets components work but not raw.

Sample project attached.
test-hammer.zip

@sachicortes
Copy link

sachicortes commented Nov 18, 2020

Try setting viewbox property value, for example with value [viewBox]="'0 0 800 100'". You can't see the svg because default value for this property is '0 0 0 0'. The other components works ok because they implement <content-loader> in their templates with the viewBox property setted. @NetanelBasal maybe setting viewBox property to null instead of '0 0 0 0' by default could solve this.

@scottpetrovic
Copy link

scottpetrovic commented Dec 4, 2020

I just came here looking for the same thing. Adding the viewbox input seems to work. So like this...

 <content-loader [viewBox]="'0 0 800 100'">
     <svg:rect x="0" y="0" rx="3" ry="3" width="100%" height="10" />
      <svg:rect x="20" y="20" rx="3" ry="3" width="80%" height="10" />
      <svg:rect x="20" y="40" rx="3" ry="3" width="70%" height="10" />
      <svg:rect x="0" y="60" rx="3" ry="3" width="100%" height="10" />
      <svg:rect x="20" y="80" rx="3" ry="3" width="80%" height="10" />
      <svg:rect x="20" y="100" rx="3" ry="3" width="70%" height="10" />
 </content-loader>

This @sachicortes

@bjornharvold
Copy link
Author

Is this a bug / feature and the docs need updating? Should I resolve this issue?

@sachicortes
Copy link

It is a bug/misconfig of the package. As I stated in my answer viewBox default value is 0 0 0 0 and should be null or other value.

@NetanelBasal
Copy link
Member

@sachicortes you're welcome to submit a PR.

@sachicortes
Copy link

@NetanelBasal will do, thanks for all the packages and info out there btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants