Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries in functional tests #1866

Open
lucacome opened this issue Apr 22, 2024 · 0 comments
Open

Add retries in functional tests #1866

lucacome opened this issue Apr 22, 2024 · 0 comments
Labels
tests Pull requests that update tests
Milestone

Comments

@lucacome
Copy link
Member

lucacome commented Apr 22, 2024

As a maintainer of NGF
I want to add retries in NGF functional tests when testing
So that if not all components of the test have been brought up yet, the test does not result in a failure.

Will run 1 of 10 specs
SSSS
------------------------------
• [FAILED] [0.573 seconds]
Basic test example [It] sends traffic [functional]
/Users/luca/src/github.com/lucacome/nginx-kubernetes-gateway/tests/suite/sample_test.go:40

  [FAILED] Expected
      <int>: 502
  to equal
      <int>: 200
  In [It] at: /Users/luca/src/github.com/lucacome/nginx-kubernetes-gateway/tests/suite/sample_test.go:47 @ 04/18/24 09:21:07.264
------------------------------
SSSSS

Summarizing 1 Failure:
  [FAIL] Basic test example [It] sends traffic [functional]
  /Users/luca/src/github.com/lucacome/nginx-kubernetes-gateway/tests/suite/sample_test.go:47

Ran 1 of 10 Specs in 15.564 seconds
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 9 Skipped
--- FAIL: TestNGF (15.57s)
FAIL
FAIL	github.com/nginxinc/nginx-gateway-fabric/tests/suite	16.087s
FAIL
make: *** [test] Error 1

We should:

  • Add retries
  • We can also add readiness probes to all our backend manifests.
@mpstefan mpstefan added the tests Pull requests that update tests label Apr 22, 2024
@mpstefan mpstefan added this to the v1.3.0 milestone Apr 22, 2024
@mpstefan mpstefan modified the milestones: v1.3.0, v1.4.0 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants