Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Gateway Settings API #1827

Closed
Tracked by #622
mpstefan opened this issue Apr 15, 2024 · 1 comment · Fixed by #1870
Closed
Tracked by #622

Implement Gateway Settings API #1827

mpstefan opened this issue Apr 15, 2024 · 1 comment · Fixed by #1870
Assignees
@sjberman
Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Milestone
v1.3.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Apr 15, 2024 •
edited by sjberman

As a user of NGF
I want to set the collection point for my traces for my installation of NGF
So that I can ensure all my traces are sent to the same collection platform.

Acceptance

  • A collection endpoint. an interval between exports, batch size, and batch count can be set for the NGF installation.
  • Implementation functionality matches the enhancement proposal.
  • The above settings are configured via the NginxProxy extension.
  • Maximum and minimum input on all settings are tested against NGINX to ensure the CRD only allows valid input.
@mpstefan mpstefan mentioned this issue Apr 15, 2024
Open
@mpstefan mpstefan added this to the v1.3.0 milestone Apr 15, 2024
@mpstefan mpstefan added enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. area/nginx-configuration Relates to nginx configuration size/large Estimated to be completed within two weeks labels Apr 15, 2024
@sjberman sjberman changed the title Implement GatewaySettings API Implement Gateway Settings API Apr 15, 2024
@mpstefan
Copy link
Collaborator Author

The mentioned branch for NginxProxy (GatewaySettings) resource — https://github.com/nginxinc/nginx-gateway-fabric/commits/feat/data-plane-crd/

@mpstefan mpstefan mentioned this issue Apr 15, 2024
Open
@sjberman sjberman self-assigned this Apr 17, 2024
This was referenced Apr 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/nginx-configuration Relates to nginx configuration enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
v1.3.0
2 participants
@mpstefan @sjberman