Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring consistency into status condition messages #1809

Open
pleshakov opened this issue Apr 5, 2024 · 0 comments
Open

Bring consistency into status condition messages #1809

pleshakov opened this issue Apr 5, 2024 · 0 comments
Milestone

Comments

@pleshakov
Copy link
Contributor

We have some inconsistent messages in status conditions of resources.

(below, we use ConditionType/Status/Reason notation)

A few examples:

  • "The route is accepted" for HTTPRoute Accepted/True/Accepted . However, we have "GatewayClass is accepted" for GatewayClass Accepted/True/Accepted.
  • "unsupported value" for Listener Accepted/False/UnsupportedValue. Note that in most other messages, first letter is capitalized.
  • "invalid backendTLSPolicy" for BackendTLSPolicy Accepted/False/Invalid. Note: first letter is not capitalized, backendTLSPolicy is spelled differently from other similar places. Needed "BackendTLSPolicy"

Acceptance criteria:

  • Come up with consistent style
  • Capture rules if necessary
  • Bring messages with accordance to the style
@mpstefan mpstefan added this to the v2.0.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants