Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kustomize to generate a single CRDs file #1886

Merged
merged 3 commits into from May 1, 2024
Merged

Use kustomize to generate a single CRDs file #1886

merged 3 commits into from May 1, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 25, 2024 •
edited

Proposed changes

Problem: We want to have a single CRDs file to make it easier to install/uninstall our CRDs.

Solution: Use kustomize to create a single file

Closes #1803

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Apr 25, 2024
@lucacome lucacome changed the title Add gateway Use kustomize to generate a single CRDs file Apr 25, 2024
lucacome
lucacome commented Apr 25, 2024
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
@lucacome lucacome force-pushed the chore/kustomize branch 2 times, most recently from eb5b001 to 766766e Compare April 26, 2024 01:27
sjberman
sjberman reviewed Apr 26, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lucacome lucacome force-pushed the chore/kustomize branch 3 times, most recently from e92e444 to 3a4cd04 Compare April 26, 2024 23:11
@lucacome lucacome marked this pull request as ready for review April 26, 2024 23:41
@lucacome lucacome requested review from a team as code owners April 26, 2024 23:41
ADubhlaoich
ADubhlaoich approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes LGTM!

@github-actions github-actions bot added the helm-chart Relates to helm chart label Apr 29, 2024
@lucacome lucacome requested a review from a team April 30, 2024 16:11
salonichf5
salonichf5 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucacome lucacome merged commit 0b0f711 into nginxinc:main May 1, 2024
40 checks passed
@lucacome lucacome deleted the chore/kustomize branch May 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@sjberman sjberman sjberman approved these changes

@salonichf5 salonichf5 salonichf5 approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use kustomize to easily manipulate our yaml files
5 participants
@lucacome @ADubhlaoich @sjberman @kate-osborn @salonichf5