Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make update-codegen fails but pipeline still passed #5446

Closed
haywoodsh opened this issue Apr 25, 2024 · 2 comments · Fixed by #5492
Closed

make update-codegen fails but pipeline still passed #5446

haywoodsh opened this issue Apr 25, 2024 · 2 comments · Fixed by #5492
Labels
bug An issue reporting a potential bug

Comments

@haywoodsh
Copy link
Contributor

haywoodsh commented Apr 25, 2024

Describe the bug
./hack/update-codegen.sh return an error but pipeline is still passing.

In local environment it runs after fixing the permission issue but it removes the content of most files in pkg/client

To Reproduce
Steps to reproduce the behavior:

```
./hack/update-codegen.sh
WARNING: generate-groups.sh is deprecated.
WARNING: Please use k[8](https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:9)s.io/code-generator/kube_codegen.sh instead.

/home/runner/go/pkg/mod/k8s.io/code-generator@v0.2[9](https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:10).3/generate-groups.sh: line 66: /home/runner/go/pkg/mod/k8s.io/code-generator@v0.29.3/generate-internal-groups.sh: Permission denied
make: *** [Makefile:81: update-codegen] Error 126
```

See errors in https://github.com/nginxinc/kubernetes-ingress/actions/runs/8817766289/job/24206399351#step:9:12

Expected behavior
Pipeline should fail if error message is produced

Your environment*
This is failing on main.

In local environment, the repo must be cloned into ~/github.com/nginxinc/kubernetes-ingress.
After running chmod +x chmod +x /Users/XXX/go/pkg/mod/k8s.io/code-generator@v0.29.3/generate-internal-groups.sh, it works as expected despite the warning message

WARNING: generate-groups.sh is deprecated.
WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead. 

Alternatives
since generate-groups.sh is deprecated, we can try upgrading the package and use kube_codegen.sh as suggested by the warning message

Copy link

Hi @haywoodsh thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@vepatel vepatel added the bug An issue reporting a potential bug label Apr 25, 2024
@haywoodsh haywoodsh mentioned this issue Apr 29, 2024
6 tasks
@haywoodsh haywoodsh linked a pull request May 7, 2024 that will close this issue
6 tasks
@haywoodsh
Copy link
Contributor Author

resolved by #5492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

2 participants