Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove -leader-election-lock-name #5388

Open
brianehlert opened this issue Apr 13, 2024 · 1 comment
Open

remove -leader-election-lock-name #5388

brianehlert opened this issue Apr 13, 2024 · 1 comment
Labels
proposal An issue that proposes a feature request

Comments

@brianehlert
Copy link
Collaborator

Remove -leader-election-lock-name and related configmap leader election maintenance code.
-enable-leader-election moved to the leases API multiple releases ago.

If a customer enables lease election and defines leader-election-lock-name they actually end up activating both the leases API code and the older configmap based lease management code.
@brianehlert brianehlert added the proposal An issue that proposes a feature request label Apr 13, 2024
@vepatel
Copy link
Contributor

vepatel commented Apr 15, 2024 •
edited

guess this is for 3.7.0 as the change was introduced in 3.4.0? https://github.com/nginxinc/kubernetes-ingress/pull/4276/files#diff-43f7b0ca4debd314bccac5167f596b1394e23a307451e41d93ddb422c66c7d9c

Also lock name is still required but the name should be exclusively that of lease object not the configMap

@danielnginx danielnginx mentioned this issue May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal An issue that proposes a feature request
Projects
NGINX Ingress Controller
Status: Todo ☑
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianehlert @vepatel