New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup procedure is not cleaning up #98
Comments
Good catch. The tests didn't account for anything other than |
After git pull, it still does not clean up for me. Only cleans up default.conf. Tried recurse set to true and false.
|
After Jinja2 update the clean up still does not work. Shall we reopen this? |
|
The new tests are passing, so I am not entirely sure that this is a bug in the role. I also tried using the same file name as in your example and it got correctly deleted. Molecule test
Have you tried updating to the latest Ansible release? The modules used behind the scenes might have been updated since Ansible |
I have Ansible 2.9.6 which is the latest available for latest Ubuntu LTS, which is Ubuntu 20.04. |
You can install the latest release using |
Got this error on mine too. Latest available ansible from
with debug
I'm getting
|
Like I mentioned in an earlier comments, there are explicit tests for this use case now, and they are all passing (https://github.com/nginxinc/ansible-role-nginx-config/blob/main/molecule/cleanup_module/converge.yml). There might be some edge cases that still cause the role to fail, but I'd need more details to be able to reproduce it myself. From what I can tell given your task output, the issue might be that the P.S.: |
@alessfg Yes, I actually just found this. Come here to write about my solution :) |
Describe the bug
The code that should trigger a conf.d/*.conf cleanup is not cleaning up
To reproduce
Steps to reproduce the behavior:
Expected behavior
I expected /etc/nginx/conf.d/*.conf to be deleted before new flies are created. But only default.conf is deleted.
Your environment:
ansible-role-nginx-config from git
nginxinc.nginx, 0.19.1
ansible: 2.9.6+dfsg-1
ubuntu 20.04
The text was updated successfully, but these errors were encountered: