Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check closest host match when looking for vhost.d/config files before checking default #1309

Open
dakotahawkins opened this issue Jul 31, 2019 · 0 comments · May be fixed by #1558
Open

Check closest host match when looking for vhost.d/config files before checking default #1309

dakotahawkins opened this issue Jul 31, 2019 · 0 comments · May be fixed by #1558

Comments

@dakotahawkins
Copy link

This would be the same thing that happens when looking for certificates, and it would allow wildcard host names to find a custom config file.
jjakob added a commit to jjakob/nginx-proxy that referenced this issue Feb 9, 2021
@jjakob
nginx.tmpl: use closest vhost.d and htpasswd files (nginx-proxy#1309)
01dfb5b 
This changes the logic for finding a matching file to the same one used
by certificates. This allows wildcard host names to find a matching
config file.

The container prints "Template error: open /etc/nginx/htpasswd: no such
file or directory" if /etc/nginx/htpasswd doesn't exist, but this
doesn't impact functionality. A fix would be to make sure that directory
is always created.
@jjakob jjakob linked a pull request Feb 9, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nginx.tmpl: use closest vhost.d and htpasswd files (#1309) jjakob/nginx-proxy
1 participant
@dakotahawkins