Env in docker-compose

[coaperator]

I have files with environment

.env_prod
VIRTUAL_HOST: api.site.com

.env_local
VIRTUAL_HOST: api.localhost.local

docker-compose has a variable VIRTUAL_HOST

version: '3.5'

services:
  distance:
    container_name: ides-back_distance
    # image: almazweb/distance
    depends_on:
      - postgres
      - redis
    build:
      context: .
      dockerfile: ./Dockerfile
    environment:
      NODE_ENV: production
      VIRTUAL_HOST: ${VIRTUAL_HOST}
      postgres_URL: postgresdb://postgres:5432
      REDIS_HOST: redis
    ports:
      - 3001:3001
    volumes:
      - ./:/app

i run
docker-compose -f .\docker-compose.staging.yml --env-file ./config/.env_local up
and I get the error in nginx-proxy container
invalid number of arguments in "server_name" directive in /etc/nginx/conf.d/default.conf:78

in general, nginx naturally does not pick up the domain name

what can you think of to get out of the situation?

[rhansen]

Please verify that Docker is properly setting the VIRTUAL_HOST environment variable on your distance container.

[thomasmerz]

@yubiuser, FYI:
when running pihole as described here it might break some other apps (in my case "Nextcloud") because of VIRTUAL_HOST "" in Dockerfile which will result in "silly" and dysfunctional entries in /etc/nginx/conf/default.conf

🚧 A workaround could be to set some Envs in docker-compose.yml like this. Any comment or thoughts on this?

[yubiuser]

I'll refer to @PromoFaux as he is our docker master

[PromoFaux]

Maybe I just don't understand docker at all, but how is the env var that is declared within the pihole docker container leaking into the nginx one?

Edit: @thomasmerz you've been keeping me busy this week. I've made a change to not declare VIRTUAL_HOST "". See here : pi-hole/docker-pi-hole#1304

I'll release it.. some time. I need to give my releasing muscles a rest ETA: If you want to try it, give it about 1/2 hour and it will be in the :dev tag

[rhansen]

how is the env var that is declared within the pihole docker container leaking into the nginx one?

nginx-proxy uses the Docker socket to inspect the environment variables that Docker has set on other containers. It uses this to discover the settings that govern how it should proxy to those containers. We have plans to migrate to labels to avoid these sorts of collisions; see #2148.

[thomasmerz]

@PromoFaux , I couldn't resist 😉 But you also kept my auto-updating (every day) also very, very busy (I thought about hourly auto-updating) 🤣

Back to business:
I'm already on latest nginx-proxy and my problem with my Nexcloud "caused by your Pi-hole image" due to VIRTUAL_HOST "" has vanished. So does it still make sense to test :dev tagged image? If so, your wish be my command 😁 Or we could wait until february to avoid a single-digit-minor-version-overflow 🤣