building for swift 2.3 and Xcode 8 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally able to solve? this: LiulietLee/Pick-Color#2 MKLayer’s superLayer observers MKRefreshControl’s parentScrollView observers MKSwitch’s parent MKSwitch It’s sad that when containing MKLayer and MKRefreshControl, current implementation requires calling `recycle` in `deinit`…
|
how to specify this commit in pods if not merged into master? |
|
@serg94 |
- Remove self, type delcaration, use lazy init, parameter same as default - Merge if-let, use optional changing for short ones, use implicit unwrapped for guaranteed, - Replace file private with private, provide public init for an open class - Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow you to build on Xcode 8 with swift 2.3 to resolve #61. Swift 3 will need to come next