Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ric_ecf_mat bug #490

Open
samuelhaugland opened this issue Jan 8, 2024 · 0 comments
Open

_ric_ecf_mat bug #490

samuelhaugland opened this issue Jan 8, 2024 · 0 comments
Labels
in integration merged into integration branch

Comments

@samuelhaugland
Copy link

Hello, I believe that there is a bug with this function.

https://github.com/ngageoint/sarpy/blob/11d19a0440725181678cff89873c6f2315c6a96d/sarpy/geometry/point_projection.py#L124C5-L124C17

On line 154:

return numpy.array([r, i, c], dtype='float64')

should be

return numpy.array([r, i, c], dtype='float64').T

Adding the transpose makes this function return the same value as the Matlab equivalent. See page 26-27 in the SICD Volume 3 document. I could be using the function incorrectly though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in integration merged into integration branch
Projects
None yet
Development

No branches or pull requests

2 participants