Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prodigal output not coherent with orf id #86

Closed
danilodileo opened this issue Jan 19, 2023 · 9 comments
Closed

prodigal output not coherent with orf id #86

danilodileo opened this issue Jan 19, 2023 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@danilodileo
Copy link
Collaborator

danilodileo commented Jan 19, 2023

The orf 'id' of prodigal output is weird. Both gff and .fna/.faa output have different names.

As reported in prodigal repository with an issue hyattpd/Prodigal#99 , the orfs get an extra "_1" or similar. this is problematic as none of gff, .fna and featurecounts tables have the same name. it will be impossible then merge the final tables.
I guess that it is an issue inside prodigal, so what we could probably do it is to write an external code (new module for sub workflow) that fix the tables after featurecounts.

@danilodileo danilodileo added bug Something isn't working enhancement New feature or request labels Jan 19, 2023
@danilodileo danilodileo self-assigned this Jan 19, 2023
@erikrikarddaniel
Copy link
Member

Right. I think this is the reading frame. Have you seen any genes with another number than 1?

@danilodileo
Copy link
Collaborator Author

yes, it depends of the orfs

@danilodileo
Copy link
Collaborator Author

danilodileo commented Jan 19, 2023

what I did was cutting the first part of the id (for example, "1_1" in "_1") and then paste it to the chr column.

@erikrikarddaniel
Copy link
Member

Is it really sometimes "1_1"? I've only seen "_1".

@danilodileo
Copy link
Collaborator Author

Screenshot 2023-01-19 at 17 29 51

here an example of table output

@erikrikarddaniel
Copy link
Member

OK. The "_n" part doesn't seem to be the reading frame, but a counter for multiple orfs on the same contig. To uniquely identify an orf you hence need to keep the full name, you can't delete anything. What do the corresponding fasta files contain in terms of identifiers?

@danilodileo
Copy link
Collaborator Author

danilodileo commented Jan 19, 2023

Screenshot 2023-01-19 at 17 39 23

these are the names in the fasta file (orfs). the figure is from eukulele output and the names in the orf column are the same as the file .faa

@erikrikarddaniel
Copy link
Member

Check the names of orfs from k141_2562 which has two in the first table.

@danilodileo
Copy link
Collaborator Author

Solved in PR #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants