EVENT.IP_ADDRESS does not hold some addresses and do crash

[FoSoFix]

for some reason my issue raised with a value of 50

while the maximum lenght is coded as 40 as seems in

connect/server/dbconf/oracle/oracle-database.sql

Line 13 in bde0bdb

IP_ADDRESS VARCHAR(40),

I did fix the Oracle with
ALTER TABLE MIRTH.EVENT MODIFY IP_ADDRESS VARCHAR2(120);

then the saved value results to be a triple private ipv4 as follows
10.56.111.229:53709, 10.190.160.116, 10.188.160.68

[pacmano1]

That a multihomed mirth engine with all those IPs?

[ab-mg-23]

If there's an X-Forwarded-For header on messages that hit the Mirth API endpoint it uses that for the IP_ADDRESS.

connect/core-server-plugins/src/com/mirth/connect/server/api/MirthServlet.java

Lines 334 to 342 in bde0bdb

	protected String getRequestIpAddress() {
	String address = request.getHeader("x-forwarded-for");
	if (address == null) {
	address = request.getRemoteAddr();
	}
	return address;
	}

[pacmano1]

Interesting @ab-mg-23 , why all three then? Meaing I would expect the single IP.

[ab-mg-23]

Client address and two pass through proxies.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

[jonbartels]

/Users/jonathan.bartels/Projects/connect/server/dbconf
./oracle/oracle-database.sql:	IP_ADDRESS VARCHAR(40),
./derby/derby-database.sql:	IP_ADDRESS VARCHAR(40),
./deltas/mysql-7-8.sql:	IP_ADDRESS VARCHAR(40)) ENGINE=InnoDB
./deltas/postgres-7-8.sql:	IP_ADDRESS VARCHAR(40))
./deltas/derby-7-8.sql:	IP_ADDRESS VARCHAR(40))
./deltas/sqlserver-7-8.sql:	IP_ADDRESS VARCHAR(40))
./deltas/oracle-7-8.sql:	IP_ADDRESS VARCHAR(40))
./postgres/postgres-database.sql:	IP_ADDRESS VARCHAR(40),
./mysql/mysql-database.sql:	IP_ADDRESS VARCHAR(40),

This would affect all DB engines and is not Oracle specific. Increasing the column the size to ~120 characters is a good workaround. 120 chars should have room for three IPv6 addresses and any separator characters.

I think the correct solution would be to properly parse the X-Forwarded-For header and store the first IP address in the comma separated list.