refactor: move listeners to the main library #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmreTech
added
p: low
MaskDuck
suggested changes
Jan 23, 2023
spifory
suggested changes
Jun 27, 2023
Co-authored-by: spifory <luvuyosilubane50@gmail.com>
ooliver1
reviewed
Dec 9, 2023
ooliver1
reviewed
Mar 23, 2024
There was a problem hiding this comment.
Works fine. Test code:
import os
from dotenv import load_dotenv
from nextcord import Client, Intents, Message
load_dotenv()
client = Client(intents=Intents(guilds=True, guild_messages=True, message_content=True))
@client.listen()
async def on_ready():
print("Bot is ready")
async def on_message(message: Message):
if message.content == "ping":
await message.channel.send("pong")
client.remove_listener(on_message)
client.add_listener(on_message)
client.run(os.environ["TOKEN"])| @@ -1292,6 +1297,92 @@ async def on_ready(): | |||
| _log.debug("%s has successfully been registered as an event", coro.__name__) | |||
| return coro | |||
|
|
|||
| def add_listener(self, func: CoroFunc, name: str = MISSING) -> None: | |||
| """The non decorator alternative to :meth:`.listen`. | |||
There was a problem hiding this comment.
I'm not sure as to if these should have versionadded, since they have been added to Client.
ooliver1
added
s: in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves listeners from
commands.Bottonextcord.Client. Closes #892.Checklist
task pyrightand fixed the relevant issues.