Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only do one curl_close #174

Closed
wants to merge 1 commit into from
Closed

Only do one curl_close #174

wants to merge 1 commit into from

Conversation

brknkfr
Copy link

@brknkfr brknkfr commented Mar 18, 2021

Fixes #172

Only do one curl_close
49b42c8 
Fixes nextcloud#172

Signed-off-by: Sebastian L <sl@momou.ch>
@violoncelloCH
Copy link
Member

thanks for the PR!
I'm just wondering why you did not simply leave the close statement on line 114 (instead of moving it to the top)?

@brknkfr
Copy link
Author

brknkfr commented Mar 29, 2021

I'm just wondering why you did not simply leave the close statement on line 114 (instead of moving it to the top)?

I just thought that the open curl session is not needed anymore after saving the response code it to the variable $canconnect, so why not closing it just right after.

But it fact, it doesn't matter. For readability it would be maybe better to leave curl_close on line 114.

@violoncelloCH
Copy link
Member

yes, let's leave it at the bottom, but only once after the if statement

@brknkfr brknkfr closed this Dec 20, 2021
@brknkfr brknkfr deleted the curl_close branch December 20, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

curl_close called two times in imap lib
2 participants
@brknkfr @violoncelloCH