Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an alternative domain splitter for IMAP authentication #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow an alternative domain splitter for IMAP authentication #151

wants to merge 2 commits into from

Conversation

peter-vanpoucke
Copy link

Fixes #150

Changes proposed in this pull request:

  • Add a configurable domain splitter to the IMAP config settings.

Peter Vanpoucke added 2 commits May 24, 2020 18:23
@peter-vanpoucke
Add domainSplitter
624f064 
Signed-off-by: Peter Vanpoucke <peter.vanpoucke@rw3.be>
@peter-vanpoucke
Add domainSplitter: check if replace is still necessary
96b712f 
Signed-off-by: Peter Vanpoucke <peter.vanpoucke@rw3.be>
@violoncelloCH
Copy link
Member

thanks for your PR!
I'm not entirely sure how this should be working tbh. I mean how can you have an email address without an @ sign?

@peter-vanpoucke
Copy link
Author

The IMAP server is setup to use short usernames, just for ease of use. So this might be a one off, but I just wanted to share the change I need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow an alternative domain splitter for IMAP authentication
2 participants
@peter-vanpoucke @violoncelloCH