Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude models from updater backup #944

Open
jplitza opened this issue Aug 12, 2023 · 3 comments
Open

Exclude models from updater backup #944

jplitza opened this issue Aug 12, 2023 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@jplitza
Copy link

jplitza commented Aug 12, 2023

Describe the feature you'd like to request

Updating my Nextcloud via webinterface is no longer possible, since the updater tries for ages to backup the models under apps/recognize/models (as well as /apps/recognize/node_modules/@tensorflow/tfjs-node-gpu/deps/lib tensorflow.so – three times thanks to not supporting symlinks).

Describe the solution you'd like

Download the models to data/ instead? That's ignored by the updater AFAIK.

Describe alternatives you've considered

Modifying/configuring the updater to exclude the path apps/recognize/models? Don't know if that's a supported feature.

@jplitza jplitza added the enhancement New feature or request label Aug 12, 2023
@github-actions github-actions bot added this to Backlog in Recognize Aug 12, 2023
@jplitza
Copy link
Author

jplitza commented Aug 12, 2023

FTR: I created nextcloud/updater#484 about the symlink support for libtensorflow.so

@marcelklehr
Copy link
Member

Yes, the path for storing the models is not ideal at the moment. It's the same for the translate, stt_whisper and llm apps.

a) The models get removed everytime an update comes in and b) they get backupped unnecessarily.

The problem with storing them in data/ is that there is no hook for the uninstall event in nextcloud, which means recognize will not be able to remove the models when it's uninstalled :/

@NotAFile
Copy link

NotAFile commented Oct 8, 2023

I don't mind the delay that much personally because I use the CLI updater, but it is a bit unfortunate because I don't have that much storage space available. That means that after one or two updates, I need to go into the backups and manually delete them, or I run completely out of disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Recognize
Backlog
Development

No branches or pull requests

3 participants