Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAW images support #1070

Open
ndl opened this issue Jan 5, 2024 · 3 comments
Open

RAW images support #1070

ndl opened this issue Jan 5, 2024 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@ndl
Copy link

ndl commented Jan 5, 2024

Describe the feature you'd like to request

The current value of IMAGE_FORMATS doesn't include the image/x-dcraw value which prevents RAW images from being scanned / recognized.

Describe the solution you'd like

I've verified that extending IMAGE_FORMATS with the value image/x-dcraw picks up all the various RAW image formats I have. This is sufficient given that Recognize uses the standard NextCloud Preview functionality and 'Camera RAW Previews' app already takes care of RAW files.

Describe alternatives you've considered

N/A.

@ndl ndl added the enhancement New feature or request label Jan 5, 2024
@github-actions github-actions bot added this to Backlog in Recognize Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Hello 👋

Thank you for taking the time to open this issue with recognize. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

Hi @ndl
Thank you for the feedback and the research you have done! This is a great addition.

@marcelklehr marcelklehr moved this from Backlog to In progress in Recognize Jan 9, 2024
@Forza-tng
Copy link

Forza-tng commented Jan 14, 2024

One more thing to think about. I believe that imagemagick requires that DNG files are handled specifically, as autodetection won't work.

https://imagemagick.org/script/formats.php

Requires an explicit image format otherwise the image is interpreted as a TIFF image (e.g. dng:image.dng).

Perhaps this is why i see lines like this in the imagemagic log file:

  <event>2024-01-14T08:18:12+00:00 0:10.739 0.480u 7.1.1 Policy php[70430]: policy.c/IsRightsAuthorized/656/Policy
  Domain: Module; rights=Unrecognized; pattern="DNG" ...</event>

ImageMagic logging can be enabled in log.xml

<logmap>
  <!-- <log output="console" events="none"/> -->
  <log output="file" events="all"/>
  <log events="None"/>
    <log filename="/var/tmp/imagemagick/Magick-%g.log"/>
  <log generations="3"/>
  <log limit="2000"/>
  <!--<log format="%t %r %u %v %d %c[%p]: %m/%f/%l/%d\n  %e"/> -->
  <log format="%t %r %u %v %d %c[%p]: %m/%f/%l/%d\n  %e"/>
</logmap>

Note that the path must be accessible and writable by the php user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Recognize
In progress
Development

No branches or pull requests

3 participants