Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isAvailable() instead of isMimeSupported()? #468

Open
jonnykl opened this issue Apr 25, 2024 · 1 comment
Open

Use isAvailable() instead of isMimeSupported()? #468

jonnykl opened this issue Apr 25, 2024 · 1 comment

Comments

@jonnykl
Copy link

jonnykl commented Apr 25, 2024

First I have to note that I didn't work with the Nextcloud code or the code of any of its apps. Maybe I just don't unterstand things right.

The drawio app always returns the supported mimetypes and returns false in the isAvailable() function if previews are disabled in the settings. Therefore it might be better to use that function instead of isMimeSupported() to check whether a preview should be generated or not (assuming the way the drawio app is implemented is correct)?

Code references:

@st3iny
Copy link
Member

st3iny commented May 12, 2024

I had a look at the code and don't quite understand the use case yet. Could you please explain what exactly is broken or doesn't work by using isMimeSupported()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants