Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty directories left after removing previews of deleted images #303

Open
pboguslawski opened this issue Jun 26, 2022 · 1 comment
Open

Empty directories left after removing previews of deleted images #303

pboguslawski opened this issue Jun 26, 2022 · 1 comment
Labels
0. to triage bug server or provider related Usually in `server` or apps specific to the formats (i.e. not this app probably)

Comments

@pboguslawski
Copy link

When v5.0.0 removes preview files of deleted images, empty preview folders (i.e. appdata_oci2qpw7ky44/preview/e/a/5/d/2/f/1) are left which consumes resources (i.e. inodes) unnecessarily.
@joshtrichards
Copy link
Member

AFAIK all deletion management is handled by the Server, not this app.

Specifically here:

https://github.com/nextcloud/server/blob/42c36c152bbbdb3b787da2b91b5702632fde81eb/lib/private/Preview/BackgroundCleanupJob.php#L65-L70

They should be getting deleted per nextcloud/server#35844, but from looking at the code I don't see how the folders ever get deleted (just files). 🤔

@joshtrichards joshtrichards added bug 0. to triage server or provider related Usually in `server` or apps specific to the formats (i.e. not this app probably) labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage bug server or provider related Usually in `server` or apps specific to the formats (i.e. not this app probably)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshtrichards @pboguslawski