Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable use of image proxies #1112

Open
iNtEgraIR2021 opened this issue Aug 27, 2022 · 4 comments
Open

enable use of image proxies #1112

iNtEgraIR2021 opened this issue Aug 27, 2022 · 4 comments

Comments

@iNtEgraIR2021
Copy link

iNtEgraIR2021 commented Aug 27, 2022

Hi,

I love this great app. Also thumbs up 馃憤馃徏 for you fast reaction to the security incident fixed in the last release.

As to my personal understanding this app downloads images straight from their (external) sources it would be a great improvement in terms of UX to me personal to be able to use an image proxy. (say images.weserv.nl or external.duckduckgo.com, or a self hosted server etc. ...).

That would increase privacy and might also decrease bandwidth usage. (say by using webp output instead of original png or jpg).

It should only take an additional user preference and a format string in DownloadImageHandler.java.

The user would enter e.g. https://weserv.images.nl?url=%s&output=webp.

Looking forward to your feedback.

Regards, Petra

@David-Development
Copy link
Member

@iNtEgraIR2021 Thank you for the proposal! Adding it in the DownloadImageHandler would only work images that are dowloaded by the app itself

  • Preview pictures in the list view
  • Favicons
  • Through the "Download images / Download articles offline" option in the menu

In the detail view images are downloaded by the WebView. In order to redirect them through an image proxy there are two options:

  1. Intercept all image requests and redirect them
  2. Rewrite all URLs in the HTML and use the image proxy there

I'm not sure which one would have less sideeffects.. both options require that the image urls have proper file extensions to match against) (I personally like the first option better). In general from a privacy standpoint I agree that it makes sense to support proxies. However quite a few publishers use advertisement etc as well which can be used for tracking so I'm not sure how big the benefit will be in the end.

@iNtEgraIR2021
Copy link
Author

iNtEgraIR2021 commented Sep 11, 2022

Hi @David-Development

thanks for looking into this 馃憤馃徏

Option 1 sounds promising to me.

@David-Development
Copy link
Member

As a side note: I added images.weserv.nl as a proxy to convert SVG favicons to webp favicons since our image loading library doesn't support SVGs. -> #1115

@iNtEgraIR2021
Copy link
Author

Thanks for working on this so quickly 馃憤
Looking forward to the integration of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants