-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve server icons #2003
Comments
May I work upon this issue? |
Sure! Let me know if you need any help. The existing script that generates the icons is at https://github.com/nextcloud/neon/blob/main/tool/generate-assets.sh |
@devesh-2002 how is it going? Do you have questions or need help implementing it? |
Hello. I am very sorry I was not able to work upon this PR due to certain reasons. I will work upon it this week and update regarding it. |
No problem, I was just wondering if you needed any pointers. |
I had a closer look at this and it is quite a lot harder than I thought. Might not even be worth to put in the time to fully implement it unless we know something is actually broken. |
The easier way might even be to implement a new API in the server that allows resolving these icons (which could also be used in the CSS to avoid embedding all the SVGs). |
https://github.com/nextcloud/server/blob/master/core/src/icons.js generates the CSS rules for the server icons. It is more complex than our naive approach, so not everything works (almost everything does though).
We should follow the code in the script and map our icons accordingly. Instead of parsing that file it should be easier to just parse https://github.com/nextcloud/server/blob/master/dist/icons.css and extract the icon names and SVGs from there.
The text was updated successfully, but these errors were encountered: