Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server icons #2003

Open
provokateurin opened this issue May 3, 2024 · 7 comments
Open

Improve server icons #2003

provokateurin opened this issue May 3, 2024 · 7 comments
Labels

Comments

@provokateurin
Copy link
Member

https://github.com/nextcloud/server/blob/master/core/src/icons.js generates the CSS rules for the server icons. It is more complex than our naive approach, so not everything works (almost everything does though).
We should follow the code in the script and map our icons accordingly. Instead of parsing that file it should be easier to just parse https://github.com/nextcloud/server/blob/master/dist/icons.css and extract the icon names and SVGs from there.

@provokateurin provokateurin added feature New feature or request good first issue Good for newcomers package: neon_framework labels May 3, 2024
@devesh-2002
Copy link

May I work upon this issue?

@provokateurin
Copy link
Member Author

Sure! Let me know if you need any help. The existing script that generates the icons is at https://github.com/nextcloud/neon/blob/main/tool/generate-assets.sh

@provokateurin
Copy link
Member Author

@devesh-2002 how is it going? Do you have questions or need help implementing it?

@devesh-2002
Copy link

Hello. I am very sorry I was not able to work upon this PR due to certain reasons. I will work upon it this week and update regarding it.

@provokateurin
Copy link
Member Author

provokateurin commented May 8, 2024

No problem, I was just wondering if you needed any pointers.

@provokateurin
Copy link
Member Author

I had a closer look at this and it is quite a lot harder than I thought. Might not even be worth to put in the time to fully implement it unless we know something is actually broken.

@provokateurin provokateurin removed the good first issue Good for newcomers label May 17, 2024
@provokateurin
Copy link
Member Author

The easier way might even be to implement a new API in the server that allows resolving these icons (which could also be used in the CSS to avoid embedding all the SVGs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants