Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tool,nextcloud)!: Generate rich object parameters #1877

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(tool,nextcloud)!: Generate rich object parameters #1877

wants to merge 2 commits into from

Conversation

provokateurin
Copy link
Member

Closes #1847

Not really useful at the moment because of the lack of discriminator support (#1231) and a way to use exhaustive switch statements.

@codecov Codecov
Copy link

codecov bot commented Apr 6, 2024 •
edited

Codecov Report

Attention: Patch coverage is 37.50000% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 29.49%. Comparing base (ec9c6aa) to head (be34dde).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   29.49%   29.49%   -0.01%     
==========================================
  Files         254      254              
  Lines       84690    84660      -30     
==========================================
- Hits        24982    24973       -9     
+ Misses      59708    59687      -21
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from ec9c6aa
dynamite 31.00% <ø> (ø) Carriedforward from ec9c6aa
dynamite_end_to_end_test 61.47% <ø> (ø) Carriedforward from ec9c6aa
dynamite_runtime 85.40% <ø> (ø) Carriedforward from ec9c6aa
neon_dashboard 92.56% <ø> (ø)
neon_framework 39.94% <ø> (ø)
neon_talk 96.50% <100.00%> (+0.01%) ⬆️
nextcloud 26.12% <20.63%> (-0.01%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from ec9c6aa

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ckages/neon/neon_talk/lib/src/widgets/message.dart 100.00% <100.00%> (ø)
...on/neon_talk/lib/src/widgets/rich_object/file.dart 65.85% <100.00%> (ø)
...neon_talk/lib/src/widgets/rich_object/mention.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/api/spreed.openapi.dart 28.05% <80.00%> (-0.05%) ⬇️
...ckages/nextcloud/lib/src/api/spreed.openapi.g.dart 12.48% <15.51%> (+<0.01%) ⬆️

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 4c998dc to 791d794 Compare April 6, 2024 21:51
@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 791d794 to 66e488e Compare April 16, 2024 18:13
@provokateurin
Copy link
Member Author

I change the patch to only be a simple object instead of the discriminator so in theory it is usable now (and also everything works). I would like to first upstream the missing parameter type and missing fields. Additionally we have to wait until the next Talk releases which will include nextcloud/spreed#12021 as the some parameters were incorrectly not typed as string before.

@provokateurin
Copy link
Member Author

Ok apparently the fix for Talk was only backport to 29. To keep supporting the broken values we'll have to change the type to oneOf<int|string> for now :/ Once 28 support is dropped we can remove the hack.

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 66e488e to 2406cda Compare April 27, 2024 07:36
@provokateurin provokateurin changed the title feat(tool,nextcloud): Generate rich object parameters feat(tool,nextcloud)!: Generate rich object parameters Apr 27, 2024
@provokateurin
chore(nextcloud): Apply compatibility spec patches after all other pa…
d888526 
…tches

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
Copy link
Member Author

PR for the fields that are missing in the current definitions is sent upstream: nextcloud/server#45424

@provokateurin
feat(tool,nextcloud)!: Generate rich object parameters
be34dde 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 2406cda to be34dde Compare May 21, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate rich object parameters from source code
1 participant
@provokateurin