Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the search input above the envelope list, we should search in subject, to and from by default #9101

Open
1 of 2 tasks
GretaD opened this issue Nov 28, 2023 · 2 comments · May be fixed by #9599
Open
1 of 2 tasks

In the search input above the envelope list, we should search in subject, to and from by default #9101

GretaD opened this issue Nov 28, 2023 · 2 comments · May be fixed by #9599
Assignees
@GretaD
Labels
3. to review enhancement filter:search testing feedback Feedback from usability testing with participants

Comments

@GretaD
Copy link
Contributor

GretaD commented Nov 28, 2023 •
edited

Is your feature request related to a problem? Please describe.

It will be more convenient if the search shortcut above the envelope will search throw more field rather than just the subject.

Describe the solution you'd like

In the search input above the envelope list, we should search in subject, to and from by default, and not only for subject matches.

Work packages

  • Implementation
  • User manual documentation

Additional context

No response
@nimishavijay nimishavijay added the testing feedback Feedback from usability testing with participants label Apr 10, 2024
@GretaD GretaD linked a pull request Apr 24, 2024 that will close this issue
Open
@ChristophWurst
Copy link
Member

To search for matches in the subject OR the to field OR the from field we need to adapt the backend search API to also allow OR-ing search criteria. Right now everything is AND-ed.

  • \OCA\Mail\Controller\MessagesController::index needs a new parameter for this
  • \OCA\Mail\Contracts\IMailSearch::findMessages / \OCA\Mail\Service\Search\MailSearch::findMessages new a new parameter
  • Put the parameter into the search query object
  • Adjust \OCA\Mail\Db\MessageMapper::findIdsByQuery and similar. Make sure the other parameters are still AND-ed, like mailbox id, thread root id, etc. Basically it becomes a big AND with a sub expression for the ORs of the search.

@hamza221
Copy link
Contributor

@ChristophWurst we don't actually need new parameters if we make it a token inside the query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GretaD GretaD

Labels
3. to review enhancement filter:search testing feedback Feedback from usability testing with participants
Projects
💌 📅 👥 Groupware team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: search on subject, to, from by default nextcloud/mail
5 participants
@ChristophWurst @joshtrichards @GretaD @hamza221 @nimishavijay