Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDN Requests are not honoured #9365

Open
miaulalala opened this issue Feb 22, 2024 · 3 comments · May be fixed by #9473
Open

MDN Requests are not honoured #9365

miaulalala opened this issue Feb 22, 2024 · 3 comments · May be fixed by #9473
Labels
1. to develop bug regression

Comments

@miaulalala
Copy link
Contributor

Steps to reproduce

Try to send MDN mail and see that it doesn't request a read receipt

Expected behavior

MDN request is added to the mail

Actual behavior

MDN request is not added to the mail as the value is always false:

mail/lib/Service/MailTransmission.php

Lines 323 to 336 in 7109f99

$messageData = new NewMessageData(
$account,
$to,
$cc,
$bcc,
$message->getSubject(),
$message->getBody(),
$attachments,
$message->isHtml(),
false,
$message->getSmimeCertificateId(),
$message->getSmimeSign() ?? false,
$message->getSmimeEncrypt() ?? false,
);

Mail app version

3.6.0-alpha3

Mailserver or service

No response

Operating system

No response

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database

MySQL

Additional info

No response
@miaulalala miaulalala added this to the v3.6.0 milestone Feb 22, 2024
@ChristophWurst
Copy link
Member

@miaulalala was this broken between v3.5 and v3.6? That would make it a potential blocker. Asking because of the assigned milestone. https://github.com/nextcloud/groupware/blob/main/processes/milestones.md#apps

@miaulalala
Copy link
Contributor Author

@miaulalala was this broken between v3.5 and v3.6? That would make it a potential blocker. Asking because of the assigned milestone. nextcloud/groupware@main/processes/milestones.md#apps

I'm not sure, I think this has been broken for a while. Stable3.4 has it too:
https://github.com/nextcloud/mail/blob/stable3.4/lib/Service/MailTransmission.php#L332

@ChristophWurst
Copy link
Member

Indeed seems to be missing since 49470b9.

So not a blocker for 3.6 but still a high priority fix.

@ChristophWurst ChristophWurst removed this from the v3.6.0 milestone Mar 13, 2024
@miaulalala miaulalala linked a pull request Mar 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug regression
Projects
💌 📅 👥 Groupware team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: honour MDN requests nextcloud/mail
2 participants
@ChristophWurst @miaulalala