Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement locking on macOS-vfs builds #6716

Open
marcotrevisan opened this issue Apr 30, 2024 · 2 comments
Open

Please implement locking on macOS-vfs builds #6716

marcotrevisan opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
enhancement enhancement of a already implemented feature/code feature: 💽 virtual filesystem os: 🍎 macOS

Comments

@marcotrevisan
Copy link

Please implement locking on macOS-vfs builds.

Client version 3.13.0-macOS-vfs is missing the lock and unlock behaviour.
In my humble opinion this feature should be a top level item in the list of the next things to implement for Mac OS VFS.

My idea of the functionality, for it to be useful, would be:

  1. "lock on Office file open" and "unlock on Office file close". Feel free to remove the "Office" word from the previous sentences.
  2. Have a context menu item in Finder to manually lock and unlock.
  3. Show a lock icon on a locked file, along with the lock owner username (or maybe the first X characters of it...) decorating the file name in Finder, highlighted with some color if possible. If the username is not easy to show, a tooltip may do! Please don't underestimate this point: a clearly visible and highlighted lock information will be spotted by the user before opening the file, and there will be less need for a custom popup on file open, like other popular vendors do.
  4. Also show the locker username in the context menu as a first level citizen.
  5. (Perhaps unnecessary if point 3 is implemented) For Office files: have a custom popup on file open warning the user that the file is locked. A subsequent popup should then arise when the file is unlocked... this also implies making the file writable again and reopening it.

@claucambra it may seem much stuff but points 1..4 are very important in my humble opinion, and points 1-2 are essential.

Thanks!

@marcotrevisan marcotrevisan added the enhancement enhancement of a already implemented feature/code label Apr 30, 2024
@claucambra claucambra self-assigned this Apr 30, 2024
@claucambra
Copy link
Collaborator

Hi @marcotrevisan this is indeed planned, just have not gotten round to this yet :)

@marcotrevisan
Copy link
Author

Thank you very much for getting back to me @claucambra!
I wanted to add my contribution to the project by trying to write some requirements that sounded good to me... I hope they're reasonable for you too ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Development

No branches or pull requests

2 participants