Bugfix to Optional parameter $userId declared before required parameter #5885
Conversation
Solution for issue nextcloud#5823 Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter Signed-off-by: Raffael <r.luthiger@huanga.com>
There was a problem hiding this comment.
This has already been addressed by #5794
The parameter should still be nullable
|
Thanks for your PR, I'll close this as it has already been addressed in the mentioned other PR. We'll spin a release with the fix soon. |
|
As long as it is solved soon, I am fine. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Optional parameter $userId declared before required parameter $path is implicitly treated as a required parameter
Since it is treated anyway as a required parameter we can define it as such as well.