Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Previews break randomly #1231

Closed
Praetorian1410 opened this issue Apr 28, 2024 · 1 comment · Fixed by nextcloud/text#5834
Closed

URL Previews break randomly #1231

Praetorian1410 opened this issue Apr 28, 2024 · 1 comment · Fixed by nextcloud/text#5834
Assignees
Labels
bug Something isn't working

Comments

@Praetorian1410
Copy link

Praetorian1410 commented Apr 28, 2024

Describe the bug
When changing a URL preview to "Show link preview" and exiting edit mode, the link disappears entirely, leaving unformatted text and removing linebreaks afterwards. Reentering edit mode causes the preview to again be rendered correctly.
This is caused by the newest collectives version and the changes to the URL preview functionality.

To Reproduce
Steps to reproduce the behavior:

  1. Write some text and add a URL to it
  2. Click on the option 'Show link preview'
  3. Notice the function working correctly while still in edit mode
  4. Save the page, click on done and the preview disappears
  5. Notice that reloading the page does not fix it
  6. Notice that returning to edit mode displays the preview again
  7. Notice also that switching back to "Text only" causes the original text with the URL behind it to be displayed correctly

Expected behavior
The URL preview should always be rendered correctly.

Screenshots
Snip while in edit mode with the text and the URL while "Text only" is set (example link: https://www.myhighlands.de/tipps/annreise/anreise-mit-der-fahre/):
image

Snip while in edit mode with "Show link preview" set:
image

snip after leaving edit mode with "Show link preview" set:
image

Server details:

  • Installation type: Nextcloud AIO (Docker, Raspberry Pi 5)
  • Collectives app version: 2.10.1
  • Nextcloud version: 29.0.0
  • PHP Version: 8.2.18
  • Database: pgsql 15.6

Client details:

  • OS: Windows 11
  • Browser: Firefox
  • Browser version: 125.0.2
  • Device: Desktop
Logs

Nextcloud log (data/nextcloud.log)

No relevant log entries

Browser log

Insert your browser log here, this could for example include:

a) No javascript log entries
b) All network logs green (200)
@Praetorian1410 Praetorian1410 added the bug Something isn't working label Apr 28, 2024
@mejo- mejo- self-assigned this May 27, 2024
mejo- added a commit to nextcloud/text that referenced this issue May 27, 2024
@mejo-
Copy link
Member

mejo- commented May 27, 2024

Thanks for the report @Praetorian1410. There is a bug in the Text app that prevents links and previews from being displayed in most cases in the read/view mode. It will get fixed with the upcoming Nextcloud 29.0.2 release in June.

backportbot bot pushed a commit to nextcloud/text that referenced this issue May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

2 participants