Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use notify_push for show add / remove of pages #1118

Open
wargreen opened this issue Feb 18, 2024 · 3 comments · May be fixed by #1288
Open

Use notify_push for show add / remove of pages #1118

wargreen opened this issue Feb 18, 2024 · 3 comments · May be fixed by #1288
Assignees
Labels
2. developing bug Something isn't working enhancement New feature or request

Comments

@wargreen
Copy link

Is your feature request related to a problem? Please describe.
When friends add / remove pages, i need to reload to see the change.
This lead multiple-create / remove when working together.

Describe the solution you'd like
Use notify_push (the Client Push app) for live update the list of pages.

Describe alternatives you've considered
Use discussion for know when i need F5

Additional context
notify_push is used for desktop client sync, deck live update etc... It seem to me that can fluidize the collective workflow.

@wargreen wargreen added the enhancement New feature or request label Feb 18, 2024
@mejo-
Copy link
Member

mejo- commented May 21, 2024

Dear @wargreen, this is already the case. Apparently the notify_push implementation broke with Collectives 2.11.0 due to a bug in @nextcloud/axios 2.5.0, but before that version changes to the page list should have get propagated via notify_push.

See initListenPush in Collective.vue for the frontend part and notifyPush() in PageService for the backend part.

Did you actually test whether this works on your instance? As mentioned, with latest Collectives release (2.11.0) it's broken, but if you still run an older instance, you should see a websocket connection to your notify_push service when loading the Collectives app.

@mejo- mejo- self-assigned this May 21, 2024
@mejo-
Copy link
Member

mejo- commented May 22, 2024

Looking into this again I now understood that synchronization via notify_push only works for sessions of the same user so far. So indeed there's more work needed to sync changes between different users.

@mejo- mejo- added bug Something isn't working 2. developing and removed needs info labels May 22, 2024
mejo- added a commit that referenced this issue May 23, 2024
Fixes: #1118

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue May 28, 2024
Fixes: #1118

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- linked a pull request May 28, 2024 that will close this issue
3 tasks
mejo- added a commit that referenced this issue May 29, 2024
Fixes: #1118

Signed-off-by: Jonas <jonas@freesources.org>
@wargreen
Copy link
Author

Yay !
Thank you for all the work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

2 participants