Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signature to app #1941

Open
mottech20 opened this issue Dec 9, 2022 · 3 comments
Open

Add signature to app #1941

mottech20 opened this issue Dec 9, 2022 · 3 comments

Comments

@mottech20
Copy link

Currently the Bookmarks app reports to have no signature.json shipped with it.

php occ integrity:check-app bookmarks
  - EXCEPTION:
    - class: OC\IntegrityCheck\Exceptions\InvalidSignatureException
    - message: Signature data not found.

I don't know how you would have to do it though.
@marcelklehr
Copy link
Member

I believe app integrity check is deprecated

@mottech20
Copy link
Author

mottech20 commented Dec 12, 2022 •
edited

True, but it doesn't (edit) show the ✔Featured icon on the Apps list (or the Apps Store) either. So if it's an official app, it would be good to have a signature at least if it doesn't require much effort. A nice-to-have.

@marcelklehr
Copy link
Member

So if it's an official app

heh, it's an open question what official means. I'll leave this open, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcelklehr @mottech20