Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase "Lock" term to make it clearer that it is a app access restriction #2806

Closed
AndyScherzinger opened this issue Jul 5, 2018 · 3 comments

Comments

@AndyScherzinger
Copy link
Member

see https://help.nextcloud.com/t/android-client-pin-fingerprint-protection-pointless/33590/2

The thread shows that the access restriction we have is/can be misinterpreted as a file access restriction while it is a app access restriction. So I think we should thus show this fact as in maybe renaming "Lock" to "App access restriction" or something like that. Not a native speaker so maybe @nextcloud/designers or @mario @tobiasKaminsky have a better term to be used here :)

@AndyScherzinger AndyScherzinger added enhancement design needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Jul 5, 2018
@tobiasKaminsky
Copy link
Member

To make it a bit clearer what we are talking about (for others):

This protects the app from starting without entering correct pin/device credentials (fingerprint, password, …).
It is not meant to protect downloaded files on internal storage.

2018-07-05-142954 2018-07-05-142957

Suggestion:

  • app protection
  • App lock
  • Lock, but with a text "prevents unauthorized people from using app"

@jancborchardt
Copy link
Member

I would say "App passcode". Because stuff like "App protection" or "App security" with "none" below it seems strange. ;)

The text below should reflect the currently enabled passcode method like it is now.

(Yes, when it’s set to passcode it will say "App passcode" and below "Passcode", but I’d say that’s ok?)

@AndyScherzinger
Copy link
Member Author

Sounds good to me 👍

@tobiasKaminsky tobiasKaminsky added good first issue approved and removed needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Jul 19, 2018
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.6.0 milestone Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants