Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information to not use @ or : in password (helm values.yaml) #4567

Open
yannik-b opened this issue Apr 21, 2024 · 2 comments
Open

Add information to not use @ or : in password (helm values.yaml) #4567

yannik-b opened this issue Apr 21, 2024 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of documentation Improvements or additions to documentation good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted Extra attention is needed

Comments

@yannik-b
Copy link

Is your feature request related to a problem? Please describe.

I had multiple issues with "unique and good" passwords in the values.yaml when these contain special characters as @ or : as they are interpreted in postgresql URI.

Describe the solution you'd like

Add a information in values.yaml above all the passwords to not use such symbols as @ and : in secrets.

Describe alternatives you've considered

  • Escape those characters before building the PostgreSQL or redis connection URIs
  • Provide a good error notice. Something better than "DATABASE_URL environment variable malformed" when I don't have to provide any DATABASE_URL env variable in values.yaml

Additional context
@yannik-b yannik-b added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Apr 21, 2024
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of documentation Improvements or additions to documentation help wanted Extra attention is needed and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Apr 22, 2024
@szaimen
Copy link
Collaborator

szaimen commented May 13, 2024

Hey, would you mind opening a PR that documents this? Thanks a lot in advance! :)

@szaimen szaimen added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label May 13, 2024
@yannik-b
Copy link
Author

Will do this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of documentation Improvements or additions to documentation good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannik-b @szaimen