Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish talk-recording geckodriver install or use chromium #2676

Open
4 of 7 tasks
szaimen opened this issue Jun 5, 2023 · 29 comments
Open
4 of 7 tasks

Finish talk-recording geckodriver install or use chromium #2676

szaimen opened this issue Jun 5, 2023 · 29 comments
Labels
2. developing Work in progress blocked dependencies enhancement New feature or request help wanted Extra attention is needed overview Overview of other issues upstream

Comments

@szaimen
Copy link
Collaborator

szaimen commented Jun 5, 2023

Things that should be done after #2645 is finished

geckodriver:

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request upstream blocked labels Jun 5, 2023
@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 5, 2023

can I improve it a bit?

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

Of course :)

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

btw, I would wait with the request to move it out of testing until we actually confirmed that it works ...

@szaimen szaimen added overview Overview of other issues dependencies labels Jun 5, 2023
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

Possibly we could alternatively as soon as chromium support comes with nextcloud/spreed#9174 switch to that...

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 5, 2023

are there differences between chromium and firefox?

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 5, 2023

are there differences between chromium and firefox?

I don't know honestly... Possibly RAM and CPU usage could be different...

@szaimen szaimen changed the title Finish talk-recording geckodriver install Finish talk-recording geckodriver install or use chromium as soon as it is available Jun 5, 2023
@szaimen

This comment was marked as resolved.

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 6, 2023

Apparently the logs are unrelated. The recording worked nonetheless. But it was not automatically shared into the conversation, I only got a notification.

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 6, 2023

  • test if using the internal signaling IP also works

Does not work

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 6, 2023

Apparently the logs are unrelated. The recording worked nonetheless. But it was not automatically shared into the conversation, I only got a notification.

so it works?

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 6, 2023

so it works?

yes :)

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 6, 2023

do you now create the issue on the aports??

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 6, 2023

do you now create the issue on the aports??

Ah yes, almost forgot

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 6, 2023

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Jun 9, 2023

The issue was closed...
So what do you to do now?
do you want to switch to chrome then or should I ask if I can take over the maintance of geckodriver?

@szaimen
Copy link
Collaborator Author

szaimen commented Jun 9, 2023

The issue was closed...
So what do you to do now?
do you want to switch to chrome then or should I ask if I can take over the maintance of geckodriver?

I would say lets wait for nextcloud/spreed#9174 to be merged and released. Then update the container to use chromium. If this works, I would say maintaining upstream geckodriver is not needed. If we cannot make it work with chromium then we can think about further steps. And thanks for the huge offer to take over the maintance of geckodriver btw! :)

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 10, 2023

It seem there are some blockers for using chromium: nextcloud/spreed#9177 (comment)

@szaimen szaimen changed the title Finish talk-recording geckodriver install or use chromium as soon as it is available Finish talk-recording geckodriver install or use chromium with Nextcloud 28 Aug 17, 2023
@jospoortvliet
Copy link
Member

It seem there are some blockers for using chromium: nextcloud/spreed#9177 (comment)

it's now merged ;-)

@szaimen szaimen changed the title Finish talk-recording geckodriver install or use chromium with Nextcloud 28 Finish talk-recording geckodriver install or use chromium Nov 15, 2023
@nickvergessen
Copy link
Member

While chromium recording is there, it is not the recommended solution

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 16, 2023

While chromium recording is there, it is not the recommended solution

I see. In that case, @Zoey2936, you offered a few comments above that you could take over the maintainership of the geckodriver package in alpine aports. Is that still the case?

@szaimen szaimen added the help wanted Extra attention is needed label Nov 16, 2023
@Zoey2936
Copy link
Collaborator

yes

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Dec 7, 2023

I've created https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/56841

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Dec 8, 2023

@szaimen can you please change the apk add line?

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 8, 2023

@szaimen can you please change the apk add line?

Will it be already available now or do we need to wait e.g. for Alpine 3.19.1?

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Dec 8, 2023

I think 3.20.0

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 8, 2023

I think 3.20.0

Okay, then I'd say lets wait for that

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Dec 8, 2023

Yes but it moved from testing to community, so this needs to be changed in the apk add line

@szaimen
Copy link
Collaborator Author

szaimen commented Dec 8, 2023

Yes but it moved from testing to community, so this needs to be changed in the apk add line

Okay, so we can already change that now or do we still need to wait for 3.19.1 for this to become available?

@Zoey2936
Copy link
Collaborator

Zoey2936 commented Dec 8, 2023

We still need to pull it from edge, but from the community branch now

@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress blocked dependencies enhancement New feature or request help wanted Extra attention is needed overview Overview of other issues upstream
Projects
None yet
Development

No branches or pull requests

4 participants