Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to handle loading 2 codebases. #173

Open
steven-esser opened this issue Jul 17, 2021 · 2 comments · May be fixed by #176
Open

Add function to handle loading 2 codebases. #173

steven-esser opened this issue Jul 17, 2021 · 2 comments · May be fixed by #176
Assignees
Labels
GSOC Project/issues to be done during the GSOC Time frame

Comments

@steven-esser
Copy link
Contributor

The following lines clutter up the __init()__ function for DeltaCode:

if os.path.isfile(new_path) and os.path.isfile(old_path):
self.codebase1 = VirtualCodebase(new_path)
self.codebase2 = VirtualCodebase(old_path)
else:
error_message = (
"{} is expected to be a file".format(new_path)
if not os.path.isfile(new_path)
else "{} is expected to be a file".format(old_path)
)
raise utils.FileError(error_message)

Create a function to handle this logic, including the various errors that may occur during loading.

@steven-esser steven-esser added the GSOC Project/issues to be done during the GSOC Time frame label Jul 17, 2021
@Pratikrocks
Copy link
Collaborator

Yes we could handle it likewise , changing it soon

@Pratikrocks Pratikrocks linked a pull request Jul 17, 2021 that will close this issue
@Pratikrocks
Copy link
Collaborator

Updated

@AyanSinhaMahapatra AyanSinhaMahapatra added this to In Progress in GSOC 2021 Deltacode Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC Project/issues to be done during the GSOC Time frame
Projects
Development

Successfully merging a pull request may close this issue.

2 participants