Added has_license and has_copyright to delta object #114
Conversation
|
@MaJuRG , this is my first Pull request, please suggest me any required changes. Thank you ! |
There was a problem hiding this comment.
@shubhscoder This is the correct first start. However, we want to populate these new field values properly in the right places.
See the various license and copyright functions in https://github.com/nexB/deltacode/blob/develop/src/deltacode/utils.py
Where we run delta.update(blah blah) we will want update these new flags for our Delta object and remove the "factors" that are added at each of these conditions.
shubhscoder
force-pushed
the
add_has_license
branch
3 times, most recently
from
aec399a
to
acf9fd6
Compare
|
@MaJuRG , I have tried updating has_license and has copyright. The remaining delta.update would I guess go with addition of status right ? Also I know why the tests are failing because we have removed the scoring system. Should I try updating and addition of "status" in this PR itself? Then probably I can try updating the tells together. Also I am not sure why DCO is failing. The expected and received signs are exactly same. |
|
Nit: please use an imperative style and not the past tense for your commit title. Also suffix it with the ticket number. And then explain in the body what this commit does See https://github.com/nexB/aboutcode/wiki/Writing-good-commit-messages |
|
also your git user config should match your signoff for the DCO bot to be happy ;) |
Update has_license and has_copyright appropriately Signed-off-by: Shubham <shubhamsangamnerkar9@gmail.com>
shubhscoder
force-pushed
the
add_has_license
branch
from
acf9fd6
to
18ec9a6
Compare
Thank you so much! I updated the commit message. |
@pombredanne , the "expected" and the "got" fields are exactly same. Also I checked with my local git, the global configuration is same as the signoff. Thank you! |
|
@shubhscoder the DCO bot may have a bug ... but in any case you need to sign with your full name. Thank you for fixing this |
|
Okay I ll do that. Thank you!
…On Fri, Mar 22, 2019, 9:57 PM Philippe Ombredanne ***@***.***> wrote:
@shubhscoder <https://github.com/shubhscoder> the DCO bot may have a bug
... but in any case you need to sign with your full name. Thank you for
fixing this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#114 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARofxSs65EO_a_kprmQpanTJ2Q6m0BYqks5vZQSHgaJpZM4b3qq1>
.
|
|
Closing due to stagnation. |
Fixes #109
Signed-off-by: Shubham shubhamsangamnerkar9@gmail.com