Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable On/Off notifications #172

Open
popod opened this issue Aug 26, 2021 · 4 comments
Open

Allow to disable On/Off notifications #172

popod opened this issue Aug 26, 2021 · 4 comments

Comments

@popod
Copy link

popod commented Aug 26, 2021

On macOS each times I manually enable/disable sleep, a notification appears.. It will be really nice to allow us to disable this.

For now I've disabled all KeepingYouAwake notifications.

Thank you :)

@newmarcel
Copy link
Owner

Hi!
This was indeed an intentional decision for this initial implementation. Right now there are only notifications for activation and deactivation, so the system-wide on/off toggle manages only these.
I wanted to avoid redundant checkboxes and therefore only placed the "Notification Preferences…" button for convenience in the General preferences pane.
That's my reasoning behind this feature.

@popod
Copy link
Author

popod commented Aug 28, 2021

Hi,

Ok, thank you for reply ! I understand your reasoning but I see two cases where (perhaps) a setting could be useful:

  • It could be nice to only view notifications when sleep is automatically disabled after one hour for example, but not when I manually enable/disable sleep. If you think that this is a good idea, I can create a dedicated issue for this feature.
  • If I disable all notifications from macOS settings and that some others kind of notifications are then added to, I could miss them and don't know that they exist.

This is just ideas and I understand that you want to keep the settings as simple as possible.

@newmarcel
Copy link
Owner

That's a very good point 👍.
I think it could be useful to separate between automatic and manual activation/deactivation events for notifications. Some people (like me ^^) prefer to have these notifications disabled, but if only automatic events cause notifications I could keep them enabled without them being noisy.

A preference toggle could let the user decide if they want notifications for all activation/deactivation events or just for automatic changes like the timeout or battery threshold.

That's very good feedback, thank you very much! I will try to have this implemented as a toggle in Preferences for the next release 😃.

@popod
Copy link
Author

popod commented Aug 30, 2021

Hi, thank you for your reply ! I'm happy to help and hope to test this in a near future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants