Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving the user the possibility to choose which module to load #137

Open
lelaus opened this issue Feb 20, 2024 · 2 comments
Open

Giving the user the possibility to choose which module to load #137

lelaus opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lelaus
Copy link
Collaborator

lelaus commented Feb 20, 2024

So far, each liquid metal class loads all the available property modules when it is instantiated.
It could be useful giving the user the possibility to select which modules to load, whether all the available ones (as now) or only a few of them.

@lelaus lelaus self-assigned this Feb 20, 2024
@lelaus lelaus added the enhancement New feature or request label Feb 21, 2024
@lelaus
Copy link
Collaborator Author

lelaus commented Mar 3, 2024

Two possible layouts have been identified:

  1. by introducing an additional argument into the constructor of the liquid metal, which would allow to select which modules to load at each instantiation;
  2. by handling the modules' selection in the same way as the selection of the correlations.

The layout #1 could be useful, but some issues would arise since the loaded modules at the class level would not be synchronized with the ones available at the instance level. Enabling this synchronization would require great modifications to the entire code layout.
The layout #2 is the chosen solution: that is, replicating for the modules what has already been done for the selection of the correlations.

@lelaus
Copy link
Collaborator Author

lelaus commented Mar 3, 2024

In addition to what stated in the above comment, the management of the modules' selection should allow also to restore the default modules' selection (in accordance to what should be implemented for the property correlations too: issue #146).

lelaus added a commit that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant