Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a pending tx during deploying/upgrading with higher gasPrice #342

Open
jcortejoso opened this issue Jul 18, 2022 · 0 comments
Open
Labels

Comments

@jcortejoso
Copy link
Contributor

jcortejoso commented Jul 18, 2022

Is your feature request related to a problem? Please describe.

When deploying the contracts if the networks conditions change abruptly, an emitted tx can have a low gasPrice for being processed, and this situation can extend during long periods (particularly in polygon networks in my experience), and the deployment process is blocked until the pending tx go though (or you unblock that somehow externally).

This is the message shown:

Error: Timed out waiting for implementation contract deployment to address 0x7A6c6f0677c254f64dF748b3Ed31FadA46BB2D32 with transaction 0x3607c01c8b8d500e52b88bc5d0f679f706884e4066fcadbdef9b9eca526b08c8
Run the function again to continue waiting for the transaction confirmation. If the problem persists, adjust the polling parameters with the timeout and pollingInterval options.

Describe the solution you'd like

It would be nice if the deployment process could detect this situation and overwrite the tx with higher gasPrice for the current network conditions. Also a simple approach that I think could work would be overwriting a tx with oldGasPrice * 10 for the tx that is pending when continuing from cached deployment.

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant