Difficulty Running Logout Script with xrdp Sessions

[ahtisham96]

I've encountered an issue with running a logout script (user_logout.sh) in my xrdp sessions. The script works perfectly fine when I start or terminate sessions using SSH, but it doesn't execute when I create or terminate sessions using the xrdp client. I added the path of the user_logout.sh inside ~/bash_logout script

I attempted to set up the startvm_and_logout script as suggested in the implementation guide, but I couldn't find the specified lines in the default startvm.sh script.

est -x /etc/X11/Xsession && exec /etc/X11/Xsession
exec /bin/sh /etc/X11/Xsession

Could someone please help me understand why my logout script isn't working with xrdp sessions and how to properly set up the startvm_and_logout script? Any assistance would be greatly appreciated. Thank you!

[matt335672]

@ahtisham96 - could you provide a bit more info:-

1. xrdp version?
2. You mention an implementation guide. What is this?

Thanks

[ahtisham96]

Hi @matt335672 Sure,

1. xrdp 0.10.80
2. https://github.com/neutrinolabs/xrdp/wiki/Running-a-user-logout-script

Is it fine, or do you need anyting else? please let me know. thanks

[matt335672]

The link's embarrassing - seems I wrote that myself a few years back!

V0.10 beta does things a little differently, and this may be causing a problem.

1. How are you ending the session?
2. Can you provide the section of xrdp-sesman.log when the session ends?

Thanks

[ahtisham96]

Okay sure @matt335672 , let me send you the few lines from xrdp-sessman.log.

1. I want to execute the script user_logout.sh when the session logs out. I have added this script to the ~/.bash_logout file, and it works fine when I start or exit the session from the command line I mean using SSH. However, I also want to call this script for xrdp sessions. Unfortunately, I haven't found any guidance from xrdp on how to set up this script to be called. It would be greatly appreciated if you could provide some guidance. Thank you.
   Note: The user_logout.sh script made by myself. I have added some commands here to update the things in a file while exiting to the session.

[2024-03-14T15:53:37.897+0000] [INFO ] X server :11 is working
[2024-03-14T15:53:37.900+0000] [INFO ] Starting window manager for display :11
[2024-03-14T15:53:37.904+0000] [INFO ] Starting the xrdp channel server for display :11
[2024-03-14T15:53:37.905+0000] [INFO ] Using the default window manager on display 11: /etc/xrdp/startwm.sh
[2024-03-14T15:53:37.911+0000] [INFO ] Session in progress on display :11. Waiting until the window manager (pid 38979) exits to end the session
[2024-03-14T15:53:38.226+0000] [INFO ] Window manager (pid 38979, display 11) finished normally in 1 secs
[2024-03-14T15:53:38.230+0000] [WARN ] Window manager (pid 38979, display 11) exited quickly (1 secs). This could indicate a window manager config problem
[2024-03-14T15:53:38.234+0000] [INFO ] Terminating X server (pid 38957) on display :11
[2024-03-14T15:53:38.236+0000] [INFO ] Terminating the xrdp channel server (pid 38980) on display :11
[2024-03-14T15:53:38.244+0000] [INFO ] X server pid 38957 on display :11 finished
[2024-03-14T15:53:38.246+0000] [INFO ] xrdp channel server pid 38980 on display :11 finished
[2024-03-14T15:53:38.249+0000] [INFO ] Session on display 11 has finished.
[2024-03-14T15:55:14.860+0000] [INFO ] sesman_main_loop: sesman asked to terminate
[2024-03-14T15:55:14.871+0000] [INFO ] starting xrdp-sesman with pid 39210
[2024-03-14T15:55:14.884+0000] [INFO ] Sesman now listening on /var/run/xrdp/sesman.socket
[2024-03-14T15:55:38.677+0000] [INFO ] sesman_main_loop: sesman asked to terminate
[2024-03-14T15:56:03.527+0000] [INFO ] starting xrdp-sesman with pid 1204
[2024-03-14T15:56:03.606+0000] [INFO ] Sesman now listening on /var/run/xrdp/sesman.socket
[2024-03-14T15:57:40.889+0000] [INFO ] Socket 13: connection accepted from AF_UNIX
[2024-03-14T15:57:40.901+0000] [INFO ] Received system login request from xrdp for user: avdadmin IP: 13.68.196.21
[2024-03-14T15:57:40.908+0000] [INFO ] starting xrdp-sesexec with pid 3534
[2024-03-14T15:57:40.932+0000] [INFO ] TerminalServerUsers group tsusers doesn't exist. Access granted for avdadmin
[2024-03-14T15:57:40.936+0000] [INFO ] Access permitted for user: avdadmin
[2024-03-14T15:57:40.939+0000] [INFO ] Received sys login status for avdadmin : logged in
[2024-03-14T15:57:40.945+0000] [INFO ] Received request from xrdp to create a session for user avdadmin
[2024-03-14T15:57:40.948+0000] [INFO ] PAM: Last login: Thu Mar 14 15:57:11 UTC 2024 from 110.37.39.139 on pts/0
[2024-03-14T15:57:40.982+0000] [INFO ] Starting X server on display 10: Xvnc :10 -auth .Xauthority -geometry 1804x977 -depth 32 -rfbauth /home/avdadmin/.vnc/sesman_passwd-avdadmin@Linux-03:10 -bs -nolisten tcp -localhost -dpi 96 
[2024-03-14T15:57:41.972+0000] [INFO ] X server :10 is working
[2024-03-14T15:57:41.976+0000] [INFO ] Starting window manager for display :10
[2024-03-14T15:57:41.980+0000] [INFO ] Starting the xrdp channel server for display :10
[2024-03-14T15:57:41.980+0000] [INFO ] Using the default window manager on display 10: /etc/xrdp/startwm.sh
[2024-03-14T15:57:41.983+0000] [INFO ] Session in progress on display :10. Waiting until the window manager (pid 3554) exits to end the session
[2024-03-14T16:00:40.928+0000] [INFO ] Window manager (pid 3554, display 10) finished normally in 179 secs
[2024-03-14T16:00:40.935+0000] [INFO ] Terminating X server (pid 3538) on display :10
[2024-03-14T16:00:40.969+0000] [INFO ] Terminating the xrdp channel server (pid 3555) on display :10
[2024-03-14T16:00:40.986+0000] [INFO ] X server pid 3538 on display :10 finished
[2024-03-14T16:00:41.411+0000] [INFO ] xrdp channel server pid 3555 on display :10 finished
[2024-03-14T16:00:41.112+0000] [INFO ] Session on display 10 has finished.

[matt335672]

@ahtisham96 - are you happy to paste your startwm.sh script which calls your user logout script? I suspect you're nearly there, and I imagine the script just needs a tweak to get it working.

[ahtisham96]

@matt335672 Sure, let me share the 'startvm.sh' script. There are three ways mentioned by XRDP on how we can call the 'user_logout.sh' script.

1. I followed the first method and added the path of my script in the '/.bash_logout' script to call it. It only works for SSH sessions. I also tried to call this function in the 'post_start()' function where it is calling '/.bash_logout', but it did not work.

2. I tried to implement the second method according to the above implementation guide but did not find the desired code in the default 'startvm.sh' script."

Note: I have only added a line to call my 'user_logout.sh' script in the 'post_start' function; nothing else has been changed.
startvm.sh

#!/usr/bin/env bash
#
# This script is an example. You might need to edit this script
# depending on your distro if it doesn't work for you.
#
# Uncomment the following line for debug:
# exec xterm


# Execution sequence for interactive login shell - pseudocode
#
# IF /etc/profile is readable THEN
#     execute /etc/profile
# END IF
# IF ~/.bash_profile is readable THEN
#     execute ~/.bash_profile
# ELSE
#     IF ~/.bash_login is readable THEN
#         execute ~/.bash_login
#     ELSE
#         IF ~/.profile is readable THEN
#             execute ~/.profile
#         END IF
#     END IF
# END IF
pre_start()
{
  if [ -r /etc/profile ]; then
    . /etc/profile
  fi
  if [ -r ~/.bash_profile ]; then
    . ~/.bash_profile
  else
    if [ -r ~/.bash_login ]; then
      . ~/.bash_login
    else
      if [ -r ~/.profile ]; then
        . ~/.profile
      fi
    fi
  fi
  return 0
}

# When logging out from the interactive shell, the execution sequence is:
#
# IF ~/.bash_logout exists THEN
#     execute ~/.bash_logout
# END IF
post_start()
{
  if [ -r ~/.bash_logout ]; then
    . ~/.bash_logout
  fi
  source ~/xrdp-scripts/user_logout.sh
  . ~/xrdp-script/update-db-username.sh
  return 0
}

get_xdg_session_startupcmd()
{
  # If DESKTOP_SESSION is set and valid then the STARTUP command will be taken from there
  # GDM exports environment variables XDG_CURRENT_DESKTOP and XDG_SESSION_DESKTOP.
  # This follows it.
  if [ -n "$1" ] && [ -d /usr/share/xsessions ] \
    && [ -f "/usr/share/xsessions/$1.desktop" ]; then
    STARTUP=$(grep ^Exec= "/usr/share/xsessions/$1.desktop")
    STARTUP=${STARTUP#Exec=*}
    XDG_CURRENT_DESKTOP=$(grep ^DesktopNames= "/usr/share/xsessions/$1.desktop")
    XDG_CURRENT_DESKTOP=${XDG_CURRENT_DESKTOP#DesktopNames=*}
    XDG_CURRENT_DESKTOP=${XDG_CURRENT_DESKTOP//;/:}
    export XDG_CURRENT_DESKTOP
    export XDG_SESSION_DESKTOP="$DESKTOP_SESSION"
  fi
}

#start the window manager
wm_start()
{
  if [ -r /etc/default/locale ]; then
    . /etc/default/locale
    export LANG LANGUAGE
  fi

  # debian
  if [ -r /etc/X11/Xsession ]; then
    pre_start

    # if you want to start preferred desktop environment,
    # add following line,
    #  [ -n "$XRDP_SESSION" ] && export DESKTOP_SESSION=<your preferred desktop>
    # in either of following file.
    # 1. ~/.profile
    # 2. create a file (any_filename.sh is OK) in /etc/profile.d
    # <your preferred desktop> shall be one of "ls -1 /usr/share/xsessions/|cut -d. -f1"
    # e.g.  [ -n "$XRDP_SESSION" ] && export DESKTOP_SESSION=ubuntu

    # STARTUP is the default startup command.
    # if $1 is empty and STARTUP was not set
    # /etc/X11/Xsession.d/50x11-common_determine-startup will fallback to
    # x-session-manager
    if [ -z "$STARTUP" ] && [ -n "$DESKTOP_SESSION" ]; then
      get_xdg_session_startupcmd "$DESKTOP_SESSION"
    fi

    . /etc/X11/Xsession
    post_start
    exit 0
  fi

  # alpine
  # Don't use /etc/X11/xinit/Xsession - it doesn't work
  if [ -f /etc/alpine-release ]; then
    if [ -f /etc/X11/xinit/xinitrc ]; then
        pre_start
        /etc/X11/xinit/xinitrc
        post_start
    else
        echo "** xinit package isn't installed" >&2
        exit 1
    fi
  fi

  # el
  if [ -r /etc/X11/xinit/Xsession ]; then
    pre_start
    . /etc/X11/xinit/Xsession
    post_start
    exit 0
  fi

  # suse
  if [ -r /etc/X11/xdm/Xsession ]; then
    # since the following script run a user login shell,
    # do not execute the pseudo login shell scripts
    . /etc/X11/xdm/Xsession
    exit 0
  elif [ -r /usr/etc/X11/xdm/Xsession ]; then
    . /usr/etc/X11/xdm/Xsession
    exit 0
  fi

  pre_start
  xterm
  post_start
}

#. /etc/environment
#export PATH=$PATH
#export LANG=$LANG

# change PATH to be what your environment needs usually what is in
# /etc/environment
#PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games"
#export PATH=$PATH

# for PATH and LANG from /etc/environment
# pam will auto process the environment file if /etc/pam.d/xrdp-sesman
# includes
# auth       required     pam_env.so readenv=1

wm_start

exit 1

[matt335672]

I think I can see what's happening here. I'm assuming you're on Debian/Ubuntu, but this is relevant for other systems.

Important lines are:-
sh

   . /etc/X11/Xsession
    post_start

The problem is that the first line never returns, as the codepath involved ends in an exec

Try removing the '.' in from of the first line so it uses an extra shell.

[ahtisham96]

@matt335672 Sorry No, I am using redhat. Let me try it if this will work then I will come back to you. Thanks

[ahtisham96]

Hi @matt335672, My access to the server was revoked on Friday. I tested it, and it's not working. I want to clarify that I am using Red Hat. Sorry for the inconvenience. I think the above solution provided for the debian/ubuntu. Thanks

[matt335672]

On RH derived systems, the file you need to edit is (I believe) /usr/libexec/xrdp/startwm.sh

Find the 'el' section rather than the 'debian' section. Same reasoning applies as above.