Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build not working on mac #88

Open
monsterkodi opened this issue Feb 13, 2024 · 3 comments · May be fixed by #101
Open

build not working on mac #88

monsterkodi opened this issue Feb 13, 2024 · 3 comments · May be fixed by #101

Comments

@monsterkodi
Copy link

building the javascript dependencies doesn't work out of the box on mac.

it seems to me that the typescript rollup plugin doesn't like something in the init.ts file.
when i try to run npm run build a second time, the error changes to something else, but still in the typescript rollup plugin.

i will attach the output of me trying to build a fresh repository clone, in case it might help:

buildfail.txt
@Kanai2003
Copy link

Hello, I'm trying to figure it out. Let's see what is happening.

@Kanai2003
Copy link

Kanai2003 commented Feb 25, 2024 •
edited

Main cause of this issue is :

Circular dependency: src/ws/websocket.ts -> src/api/extensions.ts -> src/ws/websocket.ts

@jouni-kantola I'm getting this point that there is a circular dependency between src/ws/websocket.ts
and src/api/extensions.ts

I want to try to fix this issue.

@jouni-kantola
Copy link
Contributor

@Kanai2003 I think you likely tagged the wrong person.

Kanai2003 added a commit to Kanai2003/neutralino.js that referenced this issue Feb 26, 2024
@Kanai2003
Removing circular dependency
5d6af51 
Resolve: neutralinojs#88

there is a circular dependency between `src/ws/websocket.ts`
and `src/api/extensions.ts`

```
Circular dependency: src/ws/websocket.ts -> src/api/extensions.ts -> src/ws/websocket.ts

```
removing dependency from websocket.ts
@Kanai2003 Kanai2003 linked a pull request Feb 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing circular dependency Kanai2003/neutralino.js
3 participants
@monsterkodi @jouni-kantola @Kanai2003