Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uploaded predictors deletable & ability to make public #1099

Open
yibeichan opened this issue Jan 2, 2023 · 3 comments
Open

Make uploaded predictors deletable & ability to make public #1099

yibeichan opened this issue Jan 2, 2023 · 3 comments

Comments

@yibeichan
Copy link

Describe the bug
In the document, the uploaded predictor visibility is public.
But there is no option regarding setting this visibility when uploading predictors. And, by default, I got private.

To Reproduce
Steps to reproduce the behavior:
regular uploading steps.

Expected behavior

  1. Should this attribute be changeable or not? Is it by default private?
  2. Is it possible to make uploaded predictors editable (or deletable)? (after it's being uploaded

Screenshots
In the document
image
My result
image

Desktop (please complete the following information):

  • Browser: Firefox (MacOS)

Thanks!

@yibeichan yibeichan added the bug label Jan 2, 2023
@adelavega
Copy link
Collaborator

Hi Yibei,

It's actually the case that by default they are private-- I should make that more clear in the docs.

However, I can make yours public if you wish. The reason I did not make it changeable is I don't want everyone's uploads showing up for all other users, especially if there's no verification to their accuracy.

However, I think at the minimum I should make it easier to make it public, even if by default the collections are still "private". If in the future they are causing clutter, we can re-think this, but I doubt this will be an issue for now.

After I verify that your uploads look good, I will make them public

@adelavega
Copy link
Collaborator

adelavega commented Jan 6, 2023

Editabilty is probably a bit tougher to implement, but deletable makes sense to me (although if they are already used in an analysis--- maybe not? Maybe we can do a soft delete, i.e. make them hidden/private again?)

For now, in the case you want to edit them, you can just re-upload. If we implement allowing users to "hide" or "archive" old uploads, this should work, as in the predictor search you will only see the unarchived version.

@yibeichan
Copy link
Author

Makes sense! Let me know if my uploads have any errors (e.g., formatting). If so, I'll fix them.

@adelavega adelavega changed the title uploaded predictor visibility not changeable? Make uploaded predictors deletable & ability to make public Jan 6, 2023
@adelavega adelavega added enhancement and removed bug labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants