Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to AoS layout in CoreNEURON. #2828

Open
1uc opened this issue Apr 9, 2024 · 3 comments
Open

Remove references to AoS layout in CoreNEURON. #2828

1uc opened this issue Apr 9, 2024 · 3 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Apr 9, 2024

CoreNEURON used to be able to handle the situation where some MOD files used AoS and others SoA. The functionality was removed here:
BlueBrain/CoreNeuron#675

However, there's still traces left. For example:

auto& get_mech_data_layout() {

case Layout::AoS:
return icnt * sz + isz;

We can reduce the complexity of the code by removing these. One way might be to remove the method get_mech_data_layout and then let the compiler identify all the locations that need changing.

@1uc 1uc added the enhancement label Apr 9, 2024
@mgeplf
Copy link
Collaborator

mgeplf commented May 30, 2024

First pass here: #2889
Need to go through more carefully on my end, so no need to look (but feel free).

@1uc
Copy link
Collaborator Author

1uc commented Jun 5, 2024

It's a slightly more involved process, since some code that should be simplified is still used with Layout::AoS.

@1uc
Copy link
Collaborator Author

1uc commented Jun 5, 2024

Second attempt here: #2895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants