Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image build failures - could be caught in CI before PR merge #107

Open
consideRatio opened this issue Jul 29, 2020 · 0 comments
Open

Image build failures - could be caught in CI before PR merge #107

consideRatio opened this issue Jul 29, 2020 · 0 comments
Labels
post-mortem-followup Valuable to follow up for the open source ecosystem. wontfix This will not be worked on

Comments

@consideRatio
Copy link
Member

consideRatio commented Jul 29, 2020

I opted to not setup a full staging environment alongside the production environment, it could been nice to verify in a CI system that the build of the docker image succeeded before we merged something. Otherwise, all CI deployments will fail or lead to a broken JupyterHub.

When we had prePuller.hook.enabled by default, it would fail to deploy without disrupting the JupyterHub, but with it disabled as we did when it failed due to a limit of pods per node was reached, it will instead make the hub fail to start new servers because the image is not found.

We experienced a build failure in #106, and when #103 was merged afterwards it led to the JupyterHub attempting to spawn users with an image not available. I happened to notice this 30 seconds after the JupyterHub had been corrupt and did a helm rollback operation to restore it to past functionality.

@consideRatio consideRatio added post-mortem-followup Valuable to follow up for the open source ecosystem. wontfix This will not be worked on labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mortem-followup Valuable to follow up for the open source ecosystem. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant